Fix(returndatacopy): Data offset out of bounds is still an error even if len==0 #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake in #26 by adding the early return when
len == 0
. The function is still supposed to return an error if thedata_offset
is out of bounds even if whenlen
is zero. This was causing a failure in thest_memory
EVM test.I have modified the logic to simply assign
memory_offset
as 0 iflen == 0
instead of existing the function early. This assignment is safe becausememory_offset
is not actually used in any of the memory-related functions in the caselen
is zero.All the EVM tests now once again pass.